#1 ✓hold
mrflip

HAML Templates: Pro or Con

Reported by mrflip | August 8th, 2008 @ 03:17 PM

Zachinglis (http://github.com/zachinglis/res... has put in a patch to add HAML templates. I think this should be pointed to and not pulled into mainline: generated code is a bitch to maintain, and anyone submitting code is going to only want to make & debug changes to one or the other template system.

On the other hand, the change is clean, noninteracting and only matters during the generator phase.

So: +1 if you think this should be pulled in, -1 if you think a standalone patch is appropriate. And if you have a more pragmatic solution do tell.

Comments and changes to this ticket

  • mrflip

    mrflip August 14th, 2008 @ 12:27 PM

    • State changed from “new” to “hold”
  • mrflip

    mrflip August 17th, 2008 @ 06:46 PM

    I've thought about this more, and if Zach (or anyone) is willing to move the HAML views into their own tiny little generator that would work. A separate generator within the same plugin decouples development, sits out of the way enough to avoid confusing n00bs, but gives everyone HAML views free with purchase.

    • make a new generator directory generators/authenticated_views_haml
    • copy just the HAML files into generators/authenticated_views_haml/templates/views
    • make an authenticated_views_haml_generator.rb to install them

    If you're not zachinglis, and you're interested in doing this, visit his fork on github: http://github.com/zachinglis/res...

  • Zach Inglis

    Zach Inglis August 17th, 2008 @ 06:48 PM

    In response to making this a separate generator, I am up for that.

  • Lar Van Der Jagt

    Lar Van Der Jagt August 19th, 2008 @ 02:31 AM

    +1 both on this being pulled in & for the optional generator approach.

    It looks like this is in Zach's fork already, can we get it merged in properly?

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Restful Authentication Generator

This widely-used plugin provides a foundation for securely managing user
authentication:
* Login / logout
* Secure password handling
* Account activation by validating email
* Account approval / disabling by admin
* Rudimentary hooks for authorization and access control.

http://github.com/technoweenie/restful-authentication/tree

People watching this ticket

Tags

Pages